Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-83773

CMake "Atomic" IMPORTED target should have a namespace

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • P2: Important
    • None
    • 6.0.0
    • Build System
    • None
    • All
    • 062b50abff6a3cb2319ade41dddf76caa36f27e3 (qt/qtbase/dev)

    Description

      The Qt6 CMake files define a target called "Atomic". CMake IMPORTED targets should have a namespace so that

      1) You don't clash with other SDKs (consider the problematic X11 "#define Status" )
      2) CMake knows that the name refers to a target, not a file on the filesystem. See https://cmake.org/cmake/help/latest/policy/CMP0028.html

      This target and any others which do not have a namespace should be renamed to have a double colon in the name. For example in this case, Qt6::StdAtomic.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            jbornema Joerg Bornemann
            steveire Stephen Kelly (Personal)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes