Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-89562

qt_lib_network_private.pri contains QMAKE_LIBS_OPENSSL/NOLINK entry

    XMLWordPrintable

Details

    • All
    • 4c52dd43ae69659f5b838448817d8f47ad61df21 (qt/qtbase/dev) 62031bce512558e8d21becba6752751d2859ae38 (qt/qtbase/6.2)

    Description

      The QMAKE_LIBS_OPENSSL/NOLINK entry should not exist.
      A naive attempt to fix this failed: https://codereview.qt-project.org/c/qt/qtbase/+/327313

      This patch filters simply removes the /nolink suffix from qmake libraries upon encountering them.

      With this patch, QMAKE_LIBS_OPENSSL/NOLINK is not written to qt_lib_network_private.pri. But the QMAKE_LIBS_OPENSSL_DEBUG/QMAKE_LIBS_OPENSSL_RELEASE entries are also empty.

      That's because QMAKE_LIBS_OPENSSL and QMAKE_LIBS_OPENSSL/NOLINK are now considered to be the same library, but they are actually two separate libraries:
      WrapOpenSSL and WrapOpenSSLHeaders.

      OpenSSL is the only library that is handled like that. Now, that we can break the qmake build, it might be a chance to get rid of that special case.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            jbornema Joerg Bornemann
            jbornema Joerg Bornemann
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes