Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-94753

QtFlagHandlingHelpers.cmake overrides flags -On from the user

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • P2: Important
    • None
    • 6.3
    • Build System: CMake
    • None

    Description

      Starting point: the user is always right.

      Configured with:

      cmake /home/tjmaciei/src/qt/qt6/qtbase '-GNinja Multi-Config' '-DCMAKE_INSTALL_PREFIX=/home/tjmaciei/obj/qt/qt6/qtbase' --trace-expand '-DBUILD_TESTING=ON' '-DBUILD_WITH_PCH=OFF' '-DCMAKE_DEFAULT_BUILD_TYPE:STRING=Debug' '-DCMAKE_CONFIGURATION_TYPES:STRING=Release;RelWithDebInfo;Debug' '-DCMAKE_CXX_COMPILER:STRING=g++' '-DCMAKE_CXX_FLAGS:STRING=-march=skylake-avx512 -maes -mno-rdseed' '-DCMAKE_CXX_FLAGS_DEBUG:STRING=-O0 -g3' '-DCMAKE_CXX_FLAGS_RELEASE:STRING=-O3 -g1' '-DCMAKE_CXX_FLAGS_RELWITHDEBINFO:STRING=-O3 -g' '-DCMAKE_C_COMPILER:STRING=gcc' '-DCMAKE_C_FLAGS:STRING=-march=skylake-avx512 -maes -mno-rdseed' '-DCMAKE_C_FLAGS_DEBUG:STRING=-O0 -g' '-DCMAKE_C_FLAGS_RELEASE:STRING=-O3 -g1' '-DCMAKE_C_FLAGS_RELWITHDEBINFO:STRING=-O3 -g' '-DCMAKE_MAKE_PROGRAM=/usr/bin/ninja' '-DCMAKE_EXE_LINKER_FLAGS=-Wl,-O1 -Wl,--as-needed' '-DCMAKE_SHARED_LINKER_FLAGS=-Wl,-O1 -Wl,--as-needed' '-DFEATURE_dbus_linked=OFF' '-DFEATURE_developer_build=ON' '-DFEATURE_journald=ON' '-DFEATURE_libproxy=ON' '-DFEATURE_optimize_debug=OFF' '-DFEATURE_openssl_linked=ON' '-DFEATURE_reduce_relocations=ON' '-DFEATURE_sctp=ON' '-DFEATURE_system_sqlite=ON' '-DQT_LIBINFIX=.t' '-DQT_BUILD_EXAMPLES_BY_DEFAULT=OFF' '-DQT_BUILD_TESTS_BY_DEFAULT=OFF' '-DQT_QMAKE_TARGET_MKSPEC=linux-g++-optimised'
      

      Please note the CMAKE_CXX_FLAGS_xxx settings. But later:

      $ cmake -LA -N . | grep CMAKE_CXX_FLAGS_
      CMAKE_CXX_FLAGS_DEBUG:STRING=-g3
      CMAKE_CXX_FLAGS_MINSIZEREL:STRING=-DNDEBUG -Os
      CMAKE_CXX_FLAGS_RELEASE:STRING=-g1 -O2
      CMAKE_CXX_FLAGS_RELWITHDEBINFO:STRING=-g -O2
      

      They were overridden. I want -O3 everywhere and I know better. Don't override me.

      You're welcome to add -O3 where -O2 was, but you're not allowed to lower from -O3 to -O2.

      Attachments

        For Gerrit Dashboard: QTBUG-94753
        # Subject Branch Project Status CR V

        Activity

          People

            semlanik Alexey Edelev
            thiago Thiago Macieira
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:

              Gerrit Reviews

                There is 1 open Gerrit change