Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-96870

qt_internal_generate_tool_command_wrapper might fail to generate wrapper script due to unrelated configuration failure

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • P3: Somewhat important
    • 6.3.0 Alpha
    • 6.2.0 RC2
    • Build System: CMake
    • None
    • f19f7295119d96b7606d475814328aac1d78c7cf (qt/qtbase/dev) 153c5587629c24acfe5ae17bd02955288f846cd1 (qt/qtbase/6.2)

    Description

      qt_internal_generate_tool_command_wrapper in QtBuild.cmake is supposed to generate a qt_setup_tool_path.bat file whenver QtBuild.cmake is included.

      Note that it has an early return if QT_TOOL_COMMAND_WRAPPER_PATH set.
      We set QT_TOOL_COMMAND_WRAPPER_PATH on the first call and then call file(GENERATE).
      But the file(GENERATE) might fail if an unrelated configuration error happens, and yet QT_TOOL_COMMAND_WRAPPER_PATH would already be set.

      So reconfiguring would not try to recreate the file.

      We should improve this somehow, perhaps by removing the early return, if that does not cause needless command rerunning because the file might be regenerated with different contents.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            semlanik Alexey Edelev
            alexandru.croitor Alexandru Croitor
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes