Uploaded image for project: 'Qt Quality Assurance Infrastructure'
  1. Qt Quality Assurance Infrastructure
  2. QTQAINFRA-3019

Gerrit adds spurious blank lines to commit messages when staged

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • P2: Important
    • None
    • 2019Q2, 2.16.7-2019-05-17-QtFork
    • Gerrit
    • None
    • 8da2a12a9cb4ebaf66607543e9a2379706e59d3d (qtqa/gerrit-plugin-qt-workflow/master)

    Description

      Example: PS21 of https://codereview.qt-project.org/c/qt/qtbase/+/257000

      When a commit is staged in Gerrit, it shows a new patch-set, that's got its Reviewed-by headers added; after that, it has some blank lines (possibly one per restage, not sure), which it marks in red. (Whether because it thinks they're a bad thin or because it thinks they're removed - relative to what ? - is unclear.)
      This is a visual wart that I wish it didn't inflict !

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            frederik Frederik Gladhorn
            Eddy Edward Welbourne
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes