Uploaded image for project: 'Coin'
  1. Coin
  2. COIN-1254

Windows provisioning script still doesn't exit with non-zero exit code

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: P1: Critical P1: Critical
    • None
    • master, 1.6
    • Provisioning
    • None
    • Windows
    • 5b0552550 (master)

      Previous fix (COIN-1133) by adding $? works only to show last operation status True/False.

      But in provisioning scripts are running inside a wrapper and if something fails (like ffmpeg again)

      • Script is sending Exit Code 1 (with Exit 1)
      • This cannot be read in Coin via $?

      Fortunately Windows has $LastExitCode which works better in cases like this to show the last exit code 0 or 1 (or other integer).

      Fix:

      • Change $? with $LastExitCode

      Background

      Example in log:

      ERROR: zlib requested but not found
      If you think configure made a mistake, make sure you are using the latest
      version from Git.  If the latest version fails, report the problem to the
      ffmpeg-user@ffmpeg.org mailing list or IRC #ffmpeg on irc.libera.chat.
      Include the log file "ffbuild/config.log" produced by configure as this will help
      solve the problem.
      Failed to build FFmpeg for msvc-arm64
      Ffmpeg installation results:
        mingw: OK
        llvm-mingw: OK
        android-armv7: OK
        msvc: FAIL
        msvc-arm64: FAIL
      

       

       

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            tosaario Toni Saario
            teheikki Tero Heikkinen
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:

                There are no open Gerrit changes