Details
-
Bug
-
Resolution: Done
-
P1: Critical
-
None
-
1.1
-
None
-
dd9f296b35c6f71b4fde8832156233a2cbb76e41 (qtqa/tqtc-coin-ci/master)
Description
gerritHasQtPlugin exception is not handled causing listener to crash. Occasionally while network requests drop almost certainly one failure in this method causes gerrit monitor silently to stop reading events.
syys 19 11:12:26 vmbuilder pipenv[27309]: Task exception was never retrieved syys 19 11:12:26 vmbuilder pipenv[27309]: future: <Task finished coro=<GerritListener.gerrit_ssh() done, defined at src/gerrit_monitor.py:147> exception=Exception('command failed', 'ssh -oBatchMode=yes -p 29418 codereview.qt-project.org gerrit version')> syys 19 11:12:26 vmbuilder pipenv[27309]: Traceback (most recent call last): syys 19 11:12:26 vmbuilder pipenv[27309]: File "src/gerrit_monitor.py", line 157, in gerrit_ssh syys 19 11:12:26 vmbuilder pipenv[27309]: ssh = ssh or await self._connect() syys 19 11:12:26 vmbuilder pipenv[27309]: File "src/gerrit_monitor.py", line 137, in _connect syys 19 11:12:26 vmbuilder pipenv[27309]: self.has_qt_plugin = await utils.gerritHasQtPlugin(self.config.gerrit_name) syys 19 11:12:26 vmbuilder pipenv[27309]: File "/home/vmbuilder/qt-ci/src/utils.py", line 667, in gerritHasQtPlugin syys 19 11:12:26 vmbuilder pipenv[27309]: raise Exception('command failed', " ".join(command)) syys 19 11:12:26 vmbuilder pipenv[27309]: Exception: ('command failed', 'ssh -oBatchMode=yes -p 29418 codereview.qt-project.org gerrit version')
The symptom of the problem will show lot patches with Staged status in Gerrit. The patches should be in Integrating state after some time after they are picked up by Coin.
Attachments
| For Gerrit Dashboard: COIN-383 | ||||||
|---|---|---|---|---|---|---|
| # | Subject | Branch | Project | Status | CR | V |
| 274702,4 | Handle error in gerrit monitor ssh connection | master | qtqa/tqtc-coin-ci | Status: MERGED | +2 | 0 |