Uploaded image for project: 'Coin'
  1. Coin
  2. COIN-730

Legacy instructions cause infinite recursion

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: P1: Critical
    • Resolution: Fixed
    • Affects Version/s: 1.5
    • Fix Version/s: 1.5
    • Labels:
      None
    • Commits:
      62e9d1b1323b76f9515735aff7f475d99cb42525

      Description

      Windows sets the make_command to singlemakecommand  which in turn calls make_command(itself) causing the loop.

      Jun 14 15:20:08 coin-master coin[26175]: Traceback (most recent call last):
      Jun 14 15:20:08 coin-master coin[26175]:   File "/var/lib/coin/tqtc-coin-ci/src/workitem.py", line 381, in _run
      Jun 14 15:20:08 coin-master coin[26175]:     await self.run()
      Jun 14 15:20:08 coin-master coin[26175]:   File "/var/lib/coin/tqtc-coin-ci/src/workitem.py", line 977, in run
      Jun 14 15:20:08 coin-master coin[26175]:     await self._build()
      Jun 14 15:20:08 coin-master coin[26175]:   File "/var/lib/coin/tqtc-coin-ci/src/workitem.py", line 1012, in _build
      Jun 14 15:20:08 coin-master coin[26175]:     self._result = await self._run_agent(agentLaunchRequest)
      Jun 14 15:20:08 coin-master coin[26175]:   File "/var/lib/coin/tqtc-coin-ci/src/workitem.py", line 1025, in _run_agent
      Jun 14 15:20:08 coin-master coin[26175]:     instructions = await self.get_instructions()
      Jun 14 15:20:08 coin-master coin[26175]:   File "/var/lib/coin/tqtc-coin-ci/src/workitem.py", line 971, in get_instructions
      Jun 14 15:20:08 coin-master coin[26175]:     agentInstructions = await PlatformConfigurations(self.loop)._get_agent_instructions(self.moduleConfiguration)
      Jun 14 15:20:08 coin-master coin[26175]:   File "/var/lib/coin/tqtc-coin-ci/src/platform_configurations.py", line 543, in _get_agent_instructions
      Jun 14 15:20:08 coin-master coin[26175]:     return await module.instructions(moduleConfig)
      Jun 14 15:20:08 coin-master coin[26175]:   File "/var/lib/coin/tqtc-coin-ci/src/modules.py", line 205, in instructions
      Jun 14 15:20:08 coin-master coin[26175]:     return await self.build_instructions(platformInstructions, moduleConfig)
      Jun 14 15:20:08 coin-master coin[26175]:   File "/var/lib/coin/tqtc-coin-ci/src/modules_qt5.py", line 98, in build_instructions
      Jun 14 15:20:08 coin-master coin[26175]:     platformInstructions.install()
      Jun 14 15:20:08 coin-master coin[26175]:   File "/var/lib/coin/tqtc-coin-ci/src/platforminstructions.py", line 655, in install
      Jun 14 15:20:08 coin-master coin[26175]:     super().install(args, maxTime)
      Jun 14 15:20:08 coin-master coin[26175]:   File "/var/lib/coin/tqtc-coin-ci/src/platforminstructions.py", line 329, in install
      Jun 14 15:20:08 coin-master coin[26175]:     self.executeCommand(self.make_command() + ['install', 'INSTALL_ROOT={{.InstallRoot}}'], errMsg, args, maxTime)
      Jun 14 15:20:08 coin-master coin[26175]:   File "/var/lib/coin/tqtc-coin-ci/src/platforminstructions.py", line 775, in singleJobMakeCommand
      Jun 14 15:20:08 coin-master coin[26175]:     return self.make_command() + ['-j1']
      Jun 14 15:20:08 coin-master coin[26175]:   File "/var/lib/coin/tqtc-coin-ci/src/platforminstructions.py", line 775, in singleJobMakeCommand
      Jun 14 15:20:08 coin-master coin[26175]:     return self.make_command() + ['-j1']
      Jun 14 15:20:08 coin-master coin[26175]:   File "/var/lib/coin/tqtc-coin-ci/src/platforminstructions.py", line 775, in singleJobMakeCommand
      Jun 14 15:20:08 coin-master coin[26175]:     return self.make_command() + ['-j1']
      Jun 14 15:20:08 coin-master coin[26175]:   [Previous line repeated 980 more times]
      Jun 14 15:20:08 coin-master coin[26175]: RecursionError: maximum recursion depth exceeded
      
      

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

            Assignee:
            tosaario Toni Saario
            Reporter:
            tosaario Toni Saario
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Gerrit Reviews

                There are no open Gerrit changes