Uploaded image for project: 'Qt for Python'
  1. Qt for Python
  2. PYSIDE-1016

const& shared pointers arguments generate broken code

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • Not Evaluated
    • 5.12.4, 5.13.1
    • 5.12.3
    • Shiboken
    • None
    • Linux/X11
    • fd126b28e1d9b02ea16c813bc392461bdb05bd1d (pyside-setup/5.12, 6.6.2019, 5.12.4) d21b58ef69559f4a0412f5129175b31e4450d55b (pyside/pyside-setup/5.12)

    Description

      I'll try to create a full MWE later, but wanted to report this early:

       

      namespace Foo {
struct Bar {};
using SharedBar = QSharedPointer<Bar>;
struct Asdf
{
    void take(const SharedBar& bar);
};
}

      This will lead to invalid code generation by shiboken:

      .../pytest_foo_python.h:80:33: error: parse error in template argument list
 template<> inline PyTypeObject* SbkType< ::const QSharedPointer< Foo::Bar > & >() { return reinterpret_cast<PyTypeObject*>(SbkPyTest_FooTypes[SBK_QSHAREDPOINTER_CONSTFOO_BAR_IDX]); }
                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
.../pytest_foo_python.h:80:33: error: template-id ‘SbkType<<expression error> >’ for ‘PyTypeObject* Shiboken::SbkType()’ does not match any template declaration

      Attachments

        1. 0001-WIP-Reproduce-PYSIDE-1016.patch
          4 kB
        2. pyside1016_diag.diff
          2 kB
        3. pyside1016_log.txt
          2 kB
        4. reproduce.patch
          3 kB

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. PYSIDE-753 QAspectEngine: setRootEntity not available in Python/PySide2

          • P3: Somewhat important - Should be fixed, but doesn't affect the release in any way.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. PYSIDE-1024 shared pointer SKB_*_IDX conflicts

          • Not Evaluated - Not yet evaluated/prioritized
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. PYSIDE-454 Support shared pointers in APIs

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. PYSIDE-2071 Reg->6.3.X Compilation error with shared pointers (works with 6.2.2.1, doesn't work with 6.3.2)

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed
          For Gerrit Dashboard: PYSIDE-1016
          # Subject Branch Project Status CR V
          264219,3 shiboken: Fix generation of init functions and types for const-refs of smart pointers 5.12 pyside/pyside-setup Status: MERGED +2 0
          264991,3 shiboken: Fix handling shared pointers passed by const-ref, take 2 5.12 pyside/pyside-setup Status: MERGED +2 0

          Activity

            People

              kleint Friedemann Kleint
              milianw Milian Wolff
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes