Uploaded image for project: 'Qt for Python'
  1. Qt for Python
  2. PYSIDE-1077

PySide uses wrong return codes in __init__ methods

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: P2: Important
    • Resolution: Done
    • Affects Version/s: 5.13.0
    • Fix Version/s: 5.13.1
    • Component/s: PySide
    • Labels:
      None
    • Commits:
      86f56c1ea0846540b082c67d0dc3e942fd311208 (pyside/pyside-setup/5.13)

      Description

      When certain PySide classes are initialized, the wrong return code is used for the __init__ function.
      In ignorance of the CPython API, not 0 = success and -1 = failure are used, but 1 and 0.
      This has the effect that errors are undetected until they show up at a later command prompt.

      The affected files are:

      sources/pyside2/libpyside/pysideclassinfo.cpp
      sources/pyside2/libpyside/pysideproperty.cpp
      sources/pyside2/libpyside/pysidesignal.cpp
      sources/pyside2/libpyside/pysideslot.cpp
      sources/pyside2/PySide2/QtQml/pysideqmlregistertype.cpp
      

      This error has been in the source since Nov 03, 2010.

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

            • Assignee:
              ctismer Christian Tismer
              Reporter:
              ctismer Christian Tismer
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Gerrit Reviews

                There are no open Gerrit changes