Uploaded image for project: 'Qt for Python'
  1. Qt for Python
  2. PYSIDE-1515

Shiboken wrongly assumes libclang's build type

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • P4: Low
    • None
    • None
    • Build System
    • None
    • Linux/X11
    • 8088fe1a3ab13faff3acecaa504e428a49edd58d (pyside/pyside-setup/dev) 4772406328d0e1b5b2320ada39924110455cac63 (pyside/pyside-setup/6.0)

    Description

      from shiboken_helpers.cmake:

      # CLANG_LIBRARY is read out from the cmake cache to deploy libclang
 get_target_property(CLANG_LIBRARY_NAME libclang IMPORTED_LOCATION_RELEASE)

      The build system assumes libclang is built using CMAKE_BUILD_TYPE=RELEASE instead of first checking the IMPORTED_CONFIGURATIONS value and using the build type,eg:

      get_target_property(CLANG_BUILD_TYPE libclang IMPORTED_CONFIGURATIONS)
 get_target_property(CLANG_LIBRARY_NAME libclang IMPORTED_LOCATION_${CLANG_BUILD_TYPE})

       

       

      Attachments

        For Gerrit Dashboard: PYSIDE-1515
        # Subject Branch Project Status CR V
        338236,2 shiboken6: Do not hardcode libclang's build type dev pyside/pyside-setup Status: MERGED +2 0
        338309,2 shiboken6: Do not hardcode libclang's build type 6.0 pyside/pyside-setup Status: MERGED +2 0

        Activity

          People

            kleint Friedemann Kleint
            cgiboudeaux Christophe Marin
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes