Uploaded image for project: 'Qt for Python'
  1. Qt for Python
  2. PYSIDE-2090

build shiboken generator when cross-compiling

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Invalid
    • Icon: Not Evaluated Not Evaluated
    • None
    • 6.4.0
    • Build System
    • None
    • All

       

      when cross-compiling without an available emulator to run target binaries (eg for osx/arm64), the python interpreter for the target architecture cannot be run and is marked not found by cmake (but the python libs are present)

      this results in the shiboken6 executable being skipped eventhough it can be built

      instead I propose the following patch:

      diff --git a/sources/shiboken6/generator/CMakeLists.txt b/sources/shiboken6/generator/CMakeLists.txt 
index bac998ae5..7895cb623 100644 
--- a/sources/shiboken6/generator/CMakeLists.txt 
+++ b/sources/shiboken6/generator/CMakeLists.txt 
@@ -3,7 +3,7 @@ set(package_name "Shiboken6Tools") 

 set(CMAKE_AUTOMOC ON) 

-if(NOT (Qt${QT_MAJOR_VERSION}Core_FOUND AND PYTHONINTERP_FOUND)) 
+if(NOT (Qt${QT_MAJOR_VERSION}Core_FOUND AND PYTHONLIBS_FOUND)) 
     message(WARNING "Some dependencies were not found: shiboken6 generator compilation disabled!") 
     return() 
 endif()

      this allows to provide the shiboken6 executable on conda-forge

       

      cc cgiboudeaux  kleint 

       

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            crmaurei Cristian Maureira-Fredes
            jschueller Julien Schueller
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                There are no open Gerrit changes