Details
-
Bug
-
Resolution: Done
-
P3: Somewhat important
-
None
-
5.15.4, 6.2.4, 6.3.2, 6.4.0
-
None
-
-
9adf480946 (pyside/pyside-setup/dev) 9adf480946 (pyside/tqtc-pyside-setup/dev) d15492992f (pyside/pyside-setup/6.4) d15492992f (pyside/tqtc-pyside-setup/6.4) 59efd8a241 (pyside/tqtc-pyside-setup/6.2) 9adf480946 (pyside/tqtc-pyside-setup/tqtc/dev)
Description
The limited API is documented to being enabled by default in various places:
- "default yes if applicable"
- "default yes if applicable, i.e. python version >= 3.7"
- https://code.qt.io/cgit/pyside/pyside-setup.git/tree/sources/shiboken6/cmake/ShibokenSetup.cmake#n60
- option(FORCE_LIMITED_API "Enable the limited API." "yes")
However this default actually broke/changed in https://codereview.qt-project.org/c/pyside/pyside-setup/+/230935 and it appears that was not intentional given the commit message states "In the end nothing changes, limited API builds will still be default".
The reason being that CMake options are strictly boolean values. CMake will convert the default "yes" to the standard boolean "ON". However code to read this does not expect boolean values and only compares based on literal strings:
- if(FORCE_LIMITED_API STREQUAL "yes")
Given FORCE_LIMITED_API is a boolean, this should simply read IF(FORCE_LIMITED_API).
Attachments
For Gerrit Dashboard: PYSIDE-2091 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
439339,4 | CMake: Fix check for FORCE_LIMITED_API | dev | pyside/pyside-setup | Status: MERGED | +2 | 0 |
439598,3 | Build system: Remove some outdated version checks in CMake files | dev | pyside/pyside-setup | Status: MERGED | +2 | 0 |
439599,3 | Build system: Bump versions | dev | pyside/pyside-setup | Status: MERGED | +2 | 0 |
439638,2 | Build system: Remove some outdated version checks in CMake files | 6.4 | pyside/pyside-setup | Status: MERGED | +2 | 0 |
439639,3 | Build system: Remove some outdated version checks in CMake files | tqtc/lts-6.2 | pyside/tqtc-pyside-setup | Status: MERGED | +2 | 0 |
439897,2 | CMake: Fix check for FORCE_LIMITED_API | 6.4 | pyside/pyside-setup | Status: MERGED | +2 | 0 |
439978,2 | CMake: Fix check for FORCE_LIMITED_API | tqtc/lts-6.2 | pyside/tqtc-pyside-setup | Status: MERGED | +2 | 0 |
439988,2 | Build system: Bump versions | 6.4 | pyside/pyside-setup | Status: MERGED | +2 | 0 |
440057,2 | Build system: Bump versions | 6.4.0 | pyside/pyside-setup | Status: MERGED | +2 | 0 |
440879,3 | CMake: Fix windows limited api build to work by default | dev | pyside/pyside-setup | Status: MERGED | +2 | 0 |
441223,2 | CMake: Fix windows limited api build to work by default | 6.4 | pyside/pyside-setup | Status: MERGED | +2 | 0 |
441226,2 | CMake: Fix windows limited api build to work by default | tqtc/lts-6.2 | pyside/tqtc-pyside-setup | Status: MERGED | +2 | 0 |