Uploaded image for project: 'Qt for Python'
  1. Qt for Python
  2. PYSIDE-2155

Support cmake UNITY_BUILD

XMLWordPrintable

    • Icon: Suggestion Suggestion
    • Resolution: Fixed
    • Icon: Not Evaluated Not Evaluated
    • 6.5.0
    • 6.x
    • Build System
    • None
    • All
    • 2e7fea616 (dev), 83f7993e9 (dev), e35ade028 (dev), b6d8b5f77 (dev), 68db55978 (dev), 7786dbfad (dev), fc40a3b5c (dev), 7b716e2c4 (dev), d082c3cbe (dev), 8d2d8f9c5 (dev), 2a37c2a1c (dev), 7c670b40b (dev), 5ef2f78f7 (dev), ae4131593 (dev), 6ada63dab (dev)

      pyside is a quite large project ant takes time to build

      it could be great to support cmake unity/jumbo build and greatly reduce build time:

      https://cmake.org/cmake/help/latest/prop_tgt/UNITY_BUILD.html

      I tried passing "cmake -DCMAKE_UNITY_BUILD=ON -DCMAKE_UNITY_BUILD_BATCH_SIZE=16"

      typical errors are static variables cloberring and ambiguous namespaces

      I tried to fix a few of these but did not succeed to get very far (see attached patch)

       

       

       

        1. unity.patch
          5 kB
        2. unity-1.patch
          10 kB
        3. unity-2.patch
          9 kB
        4. unity-3.patch
          15 kB
        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            crmaurei Cristian Maureira-Fredes
            jschueller Julien Schueller
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                There is 1 open Gerrit change