Uploaded image for project: 'Qt for Python'
  1. Qt for Python
  2. PYSIDE-2176

5.15.8 doesn't build on Python>=3.10 without limited API

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • P2: Important
    • 5.15.9
    • 5.15.9
    • Build System
    • None
    • Linux/X11

    Description

      This is similar to PYSIDE-1775, and has resurfaced again in 5.15.8 (which is not available for selecting in the version field btw). The culprit is this change

      --- pyside-setup-opensource-src-5.15.7/sources/shiboken2/libshiboken/pep384impl.cpp	2022-09-23 08:47:20.000000000 +0200
      +++ pyside-setup-opensource-src-5.15.8/sources/shiboken2/libshiboken/pep384impl.cpp	2023-01-04 08:07:17.000000000 +0100
      @@ -751,7 +751,7 @@
       #endif // IS_PY2
           Shiboken::AutoDecRef privateobj(PyObject_GetAttr(
               reinterpret_cast<PyObject *>(Py_TYPE(self)), Shiboken::PyMagicName::name()));
      -#if !defined(Py_LIMITED_API) && PY_VERSION_HEX < 0x03010000
      +#ifndef Py_LIMITED_API
           return _Py_Mangle(privateobj, name);
       #else
           // PYSIDE-1436: _Py_Mangle is no longer exposed; implement it always.
      

      which removed the Python version check to decide whether to use the custom PyMangle implementation.

      By the way: it would be really useful if the public git repo was updated to the latest open source release, similar to the c++ Qt modules. Otherwise it is really difficult to bisect issues.

       

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            crmaurei Cristian Maureira-Fredes
            arojas Antonio Rojas
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes