Uploaded image for project: 'Qt for Python'
  1. Qt for Python
  2. PYSIDE-2440

Type hints should indicate optionality

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • P4: Low
    • Some future version
    • 6.5.2
    • Type hints
    • None
    • Windows

    Description

      QtWidgets.pyi indicates that QApplication.activeModalWidget returns a QWidget:

      def activeModalWidget() -> PySide6.QtWidgets.QWidget: ...

      However, this code demonstrates that activeModalWidget can also return None:

      from PySide6.QtWidgets import QApplication
app = QApplication()
widget = app.activeModalWidget()
print(type(widget))  # prints "<class 'NoneType'>"

      So the correct type hint would be 

      [...] -> PySide6.QtWidgets.QWidget | None: ...

      The same is true for many other functions, one example being QTableWidget.item.

      Attachments

        Issue Links

          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. PYSIDE-2519 [Type Hints] Return type for QLayout.itemAtPosition must be optional

          • P4: Low - Would be nice to fix, but it's not very important.
          • Closed

          Suggestion - Public suggestions PYSIDE-2566 Respect "None" in type stubs

          • Not Evaluated - Not yet evaluated/prioritized
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. PYSIDE-1467 QCoreApplication.instance() should hint return as optional

          • P3: Somewhat important - Should be fixed, but doesn't affect the release in any way.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. PYSIDE-2638 Segfault when adding None to Layout

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed
          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              adherrma Adrian Herrmann
              bers bers bers
              Votes:
              3 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:

                Gerrit Reviews

                  There are no open Gerrit changes