Uploaded image for project: 'Qt for Python'
  1. Qt for Python
  2. PYSIDE-2764

backwards compatiblity issue shiboken

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • P3: Somewhat important
    • 6.7.2, 6.8.0
    • 6.7, 6.7.0
    • PySide, Shiboken
    • None
    • NixOS, Nixpkgs
    • 4f9a20e36 (dev), c3247098c (6.7), e181819c1 (dev), c07d7a7bd (6.7)

    Description

      With version 6.7.0 there seems to be an issue with backwards compatibility, introduced in commit 5d05065b57f5e37c2229ff6a2d98d936c5c7f2bb in the code generator. The commit itself claims its backwards compatible, however, trying to build Cutter (https://github.com/rizinorg/cutter) with 6.7.0 fails.

      Since 6.7.0 there is no export for this type in the generated file `cutterbindings_python.h`.

      In my opinion, to be fully backwards compatible, the code generator has to emit the type again in the file `sources/shiboken6/generator/shiboken/headergenerator.cpp` in the function `finishGeneration`:

       macrosStream << "extern PyTypeObject **" << cppApiVariableNameOld() << ";\n\n";
      

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            martin_joerg Martin Joerg
            jmpunkt Jonas Meurer
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes