Uploaded image for project: 'Qt for Python'
  1. Qt for Python
  2. PYSIDE-2822

PY_LIMITED_API definition should not be exported to downstream targets

    XMLWordPrintable

Details

    • Bug
    • Resolution: Out of scope
    • Not Evaluated
    • None
    • 6.7.2
    • Shiboken
    • None
    • Linux/Wayland, Linux/X11, Linux/Other display system, macOS

    Description

      Currently PY_LIMITED_API is propagated to downstream projects via ${PREFIX}/lib/cmake/Shiboken6/Shiboken6Targets.cmake:

      set_target_properties(Shiboken6::libshiboken PROPERTIES
  INTERFACE_COMPILE_DEFINITIONS "Py_LIMITED_API=0x03060000;NDEBUG"
  INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/include/shiboken6"
)

      If there is no obvious reason for forcing downstream projects to use the PY_LIMITED_API please change this code sequence to not include the PY_LIMITED_API:

       

      set_target_properties(Shiboken6::libshiboken PROPERTIES
  INTERFACE_COMPILE_DEFINITIONS "NDEBUG"
  INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/include/shiboken6"
)

       

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            kleint Friedemann Kleint
            looooo looooo
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes