Uploaded image for project: 'Qt for Python'
  1. Qt for Python
  2. PYSIDE-3029

Incomplete type hint for QAction.__init__ icon parameter

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Not Evaluated
    • 6.9.1, 6.10.0
    • 6.8.2
    • Type hints
    • None
    • 2f55adcea (dev), be6437d6b (6.9)

    Description

      The _init_ methods of QAction constrain the type of the icon parameter to only QIcon. However, the setIcon method accepts QIcon and QPixmap.

      The type of icon should be `QIcon | QPixmap`.

      Attachments

        For Gerrit Dashboard: PYSIDE-3029
        # Subject Branch Project Status CR V
        640642,2 type-hints: Fix properties on __init__ functions dev pyside/pyside-setup Status: MERGED +2 0
        641310,2 type-hints: Fix properties on __init__ functions 6.9 pyside/pyside-setup Status: MERGED +2 0

        Activity

          People

            ctismer Christian Tismer
            adrien-lsh Adrien Louis-Joseph
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes