Details
-
Bug
-
Resolution: Incomplete
-
Not Evaluated
-
None
-
6.8.2
-
None
Description
The commit "setup: fix PySide6._all_ after the wheel split, amendment 2" a27a9bf413288cbadf64188fe9a8a3fc6a6f1b9c https://codereview.qt-project.org/c/pyside/pyside-setup/+/598769 breaks the windows debug build.
This is a regression of the fix done for the Linux build PYSIDE-1890
Reverting a27a9bf again, fixes the build issue for the windows debug config.
The problem with the new code in _find_all_qt_modules is, that it attaches for the windows build now a _'d' debug postfix to the modules that should get build, resulting in a wrong module comparison in generate_all_pyi() when creating the 'errors' list. When generate_all_pyi() gets executed, the variable name_list is e.g. 'QtCore' whereas PySide6.all__ now has 'QtCore_d'
def generate_all_pyi(outpath, options): ... name_list = PySide6.__all__ if options.modules == ["all"] else options.modules errors = ", ".join(set(name_list) - set(PySide6.__all__)) if errors: raise ImportError(f"The module(s) '{errors}' do not exist")
Error dump:
Traceback (most recent call last): File "D:\PySideBuild\sources\pyside6\PySide6\support\generate_pyi.py", line 101, in <module> generate_all_pyi(outpath, options=options) File "D:\PySideBuild\sources\pyside6\PySide6\support\generate_pyi.py", line 57, in generate_all_pyi raise ImportError(f"The module(s) '{errors}' do not exist") ImportError: The module(s) 'QtCore' do not exist error: Error compiling pyside6 Traceback (most recent call last): File "d:\PySideBuild\setup.py", line 43, in <module> setup_runner.run_setup() File "d:\PySideBuild\build_scripts\setup_runner.py", line 264, in run_setup raise RuntimeError(msg) RuntimeError: setup.py invocation failed with exit code: 1.setup.py invocation was: D:\PySideBuild\testenv_d\Scripts\python_d.exe d:\PySideBuild\setup.py build --qtpaths=d:\PySideBuild\deps\qtdeb\bin\qtpaths.exe --openssl=d:\PySideBuild\deps\openssl\debug\bin --ignore-git --parallel=8 --debug --module-subset=Core,Gui,Widgets --internal-build-type=pyside6
Attachments
Issue Links
- relates to
-
PYSIDE-1890 Cmake build broken in 6.3.0
-
- Closed
-