Uploaded image for project: 'Qt for Python'
  1. Qt for Python
  2. PYSIDE-467

Shiboken2 does not compile with MSVC 2013

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: P2: Important
    • Resolution: Done
    • Affects Version/s: dev
    • Fix Version/s: dev
    • Component/s: Shiboken
    • Labels:
      None
    • Environment:
      Windows 7 SP1, MSVC 2013 (x64)
    • Commits:
      44029a7ff13d49619c36628b4e958415c821986f (shiboken/dev)

      Description

      Shiboken does not compile with MSVC 2013 (not tested on previous versions).
      First cause is the concatenation of string literals using C++11 features, which seems to be not correctly supported by MSVC (see here and here)
      For example, this code:

      qCWarning(lcShiboken).noquote().nospace()
                      << QStringLiteral("skipping function '%1::%2', 'void' encountered at parameter "
                                        "position %3, but it can only be the the first and only "
                                        "parameter")
      

      leads to the following error:

      error C2308: concatenating mismatched strings
      

      Second reason is a duplication of the class name in method definition in abstractmetabuilder.cpp:

      AbstractMetaClassList AbstractMetaBuilder::AbstractMetaBuilder::classesTopologicalSorted(const AbstractMetaClass *cppClass) const
      {
          return d->classesTopologicalSorted(cppClass);
      }
      

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

            Assignee:
            kleint Friedemann Kleint
            Reporter:
            jumarock Jumarock Belpecajo
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Gerrit Reviews

                There are no open Gerrit changes