Uploaded image for project: 'Qt for Python'
  1. Qt for Python
  2. PYSIDE-550

Fix the QML Private includes detection mechanism

    Details

    • Type: Bug
    • Status: Open
    • Priority: P3: Somewhat important
    • Resolution: Unresolved
    • Affects Version/s: 5.6, 5.9, dev
    • Fix Version/s: None
    • Component/s: PySide
    • Labels:
    • Environment:
      Debian testing

      Description

      In libpyside/CMakeLists.txt we have a hacky piece of code that assumes that if qtcore private headers are available, then qml / quick private headers should also be available, and simply rewrites "QtCore" to "QtQml" in the paths, without checking if the private headers actually exist.

      This causes a build failure on Debian Testing where all private include headers are separated into different packages, and thus it is possible to have qtcore private headers installed, but not qml ones.

      Build errors look like

      from /home/ale/tmp/pyside-setup/testenv3d_build/py3.5-qt5.7.1-64bit-debug/pyside2/libpyside/signalmanager.cpp:65:
      from /home/ale/tmp/pyside-setup/testenv3d_build/py3.5-qt5.7.1-64bit-debug/pyside2/libpyside/signalmanager.cpp:65:/usr/include/x86_64-linux-gnu/qt5/QtQml/5.7.1/QtQml/private/qv4jsir_p.h:58:39: fatal error: QtCore/private/qnumeric_p.h: No such file or directory
       #include <QtCore/private/qnumeric_p.h>
      

      and

      testenv3_build/py3.5-qt5.7.1-64bit-release/pyside2/libpyside/signalmanager.cpp:65:37: fatal error: private/qv4engine_p.h: No such file or directory
      #include <private/qv4engine_p.h>
      

      The code should be fixed to do proper detection.

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

            • Assignee:
              ctismer Christian Tismer
              Reporter:
              alexandru.croitor Alexandru Croitor
            • Votes:
              2 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:

                Gerrit Reviews

                There are no open Gerrit changes