Uploaded image for project: 'Qt for Python'
  1. Qt for Python
  2. PYSIDE-552

Qt5Designer required before being searched for

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • Not Evaluated
    • 5.6
    • None
    • PySide
    • None
    • 117e0ff91275b4bc06dd5383f19e7028c5ef6ff8

    Description

      This causes QtUiTools not to be available, and subsequently a build of FreeCAD to fail.

      diff --git a/sources/pyside2/CMakeLists.txt b/sources/pyside2/CMakeLists.txt
      index 929a06db..d74b64f1 100644
      --- a/sources/pyside2/CMakeLists.txt
      +++ b/sources/pyside2/CMakeLists.txt
      @@ -240,9 +240,11 @@ ENDIF()
       COLLECT_MODULE_IF_FOUND(TextToSpeech opt)
       COLLECT_MODULE_IF_FOUND(Charts opt)
       COLLECT_MODULE_IF_FOUND(Svg opt)
      +find_package(Qt5Designer)
       if(Qt5Designer_FOUND)
           COLLECT_MODULE_IF_FOUND(UiTools opt)
       else()
           set(DISABLE_QtUiTools 1)
       endif()
       COLLECT_MODULE_IF_FOUND(WebChannel opt)
      @@ -356,7 +358,6 @@ endif()
       
       add_subdirectory(libpyside)
       find_package(Qt5UiTools)
      -find_package(Qt5Designer)
       if(Qt5UiTools_FOUND AND Qt5Designer_FOUND)
           add_subdirectory(plugins)
       endif()
      

      Commit cbff5054c0ae3cc645164c05b450190c024d0839

      Attachments

        For Gerrit Dashboard: PYSIDE-552
        # Subject Branch Project Status CR V

        Activity

          People

            Unassigned Unassigned
            ysangkok Janus Troelsen
            Votes:
            2 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes