Uploaded image for project: 'Qt for Python'
  1. Qt for Python
  2. PYSIDE-612

Standalone macOS wheel naming do not respect explicitly defined deployment target

    Details

    • Type: Bug
    • Status: Closed
    • Priority: P3: Somewhat important
    • Resolution: Done
    • Affects Version/s: 5.6, 5.9, dev
    • Fix Version/s: 5.6, 5.9
    • Component/s: PySide
    • Labels:
      None
    • Commits:
      e0a4372160d9b1ab1550589784cc456b93d28cab

      Description

      When building standalone wheels for macOS and defining the deployment target explicitly, the resulting wheel filenames are e.g.:

      PySide2-5.9-cp27-cp27m-macosx_10_6_intel.whl
      PySide2-5.9-cp35-cp35m-macosx_10_6_intel.whl
      PySide2-5.9-cp36-cp36m-macosx_10_6_intel.whl

      In this case, I used Python from python.org (built on macOS 10.6) but I defined the deployment target to be macOS 10.10 (--osx-deployment-target=10.10).

      So the filenames inherit the platform used when building Python, not the deployment target platform. I would propose the built wheels should instead be named (or renamed) into saying the following in my particular scenario described here:

      PySide2-5.9-cp27-cp27m-macosx_10_10_intel.whl
      PySide2-5.9-cp35-cp35m-macosx_10_10_intel.whl
      PySide2-5.9-cp36-cp36m-macosx_10_10_intel.whl

        Attachments

          Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            Activity

              People

              • Assignee:
                alexandru.croitor Alexandru Croitor
                Reporter:
                fredrikaverpil Fredrik Averpil
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Gerrit Reviews

                  There are no open Gerrit changes