Uploaded image for project: 'Qt for Python'
  1. Qt for Python
  2. PYSIDE-682

Add setup.py check when passing --jobs and using nmake

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Reported
    • Priority: P2: Important
    • Resolution: Unresolved
    • Affects Version/s: 5.6, 5.9
    • Fix Version/s: None
    • Component/s: PySide
    • Labels:
    • Environment:
      Windows

      Description

      Nmake doesn't support -j parameter, yet a user can pass --jobs, and this leads to a build failure without printing any useful information.

      Compiling module shiboken2...
      Running process in c:\pyside-setup\pyside3_build\py3.6-qt5.11.0-64bit-release\shiboken2: "C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\BIN\amd64\nmake.exe" -j1
       
      error: Error compiling shiboken2
      

      We should exit early the build with a error message that nmake does not support -j.

      Also, this is a good test case to see why nmake doesn't give any useful failure info, perhaps stderr is not piped?

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

            • Assignee:
              alexandru.croitor Alexandru Croitor
              Reporter:
              alexandru.croitor Alexandru Croitor
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:

                Gerrit Reviews

                There is 1 open Gerrit change