Uploaded image for project: 'Qt for Python'
  1. Qt for Python
  2. PYSIDE-795

Improve Integration of Numeric Packages

    XMLWordPrintable

    Details

    • Type: User Story
    • Status: In Progress
    • Priority: P2: Important
    • Resolution: Unresolved
    • Affects Version/s: 5.11.0
    • Fix Version/s: 5.14
    • Component/s: PySide, Shiboken
    • Labels:
      None

      Description

      The Current Status

      Initially, NumPy support suffered heavily from

      • wrong documentation
      • implementation of arbitrary APIs
      • mismatch between C++/XML and the Python signatures.

      Meanwhile, several actions have been performed:

      • error messages are created inĀ Python, using the signature module
      • object protocols are more consequently using PySequence
      • signatures support the <array\> attribute for primitive type pointers
      • signatures understand generic types like List[t], Sequence[t] and Iterator[t]

      Still, there are oversights and omissions. For instance:

      >>> from PySide2 import *
      >>> QtGui.QMatrix4x4(list(range(16)))
      PySide2.QtGui.QMatrix4x4((0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15))
      >>> QtGui.QMatrix4x4(range(16))
      ### guess what?
      

      This works fine with Python2.
      With Python3, this gives a crash. Why?

      • range(16) is a List object in Python2
      • range(16) is a lazy Sequence object in Python3. This is almost like the xrange object in Python2.

      Full discussion of Python 3's range compared with Python2's xrange function can be found in https://treyhunner.com/2018/02/python-3-s-range-better-than-python-2-s-xrange/.

      There is a common misunderstanding concerning range, because it has lazy behavior, but is not an iterator! I reant that distiction myself after reading https://treyhunner.com/2018/02/python-range-is-not-an-iterator/..

      The fix is quite simple, btw. What is difficult is handling the many cases where a change is necessary. This needs an extra section, see below.

      Phase 2 of Improved NumPy support:

      All array-like interfaces that use typing.List or typing.Sequence[t] will be changed to support the most general typing.Iterable[t] API. What does that mean?

      Supporting the Iterator Protocol

      The iterator protocol is partially quite complicated and partially quite easy.

      1. Complicated: Create objects that support the iterator protocol.
      2. Easier: Interface to objects that support typing.Iterable.

      We restrict ourselves to the easy part: If an object supports it, then we use the iterator protocol.
      Example: We will be able to use iter(range(16)) for the data of a QMatrix4x4 object.

      Comparison Of Methods: Iterable vs. Sequence

      The distinction between Iterables and sequences is not tied to some explizit type.
      Python uses duck typing, instead: https://en.wikipedia.org/wiki/Duck_typing.
      Important is do understand the difference between Iterable and Iterator, which is a bit more.

      Strategy For Moving Forward to Iterables

      The transition from PySequence to Iterable is unfortunately not simple. The current
      implementation is a conglomerate of XML snippets in the XML files that are used
      to generate all classes. Then these XML files contain quite a number of links to code
      snippets that are either in the new snippet files (PySide2/glue/qtcore.cpp) or use template files which exist since a long time (PySide2/templates/core_common.xml).
      They all share one major design flaw:

      • they are mixing parameter list adaption and algorithmic calls

      After quite some attempts to change this in a general way, the following concept was
      developed:

      • Preserve the status quo
        In order to make sure that no functionality is lost in any transition, new tests are
        written that
        • test that all kinds of PySequence are supported where it is claimed
      • Move algorithmic code into a single file with a few, central functions
      • Then extent the implementation and the tests to support Iterables everywhere
        as well.

      This is currently happening.

      Phase 3 of Improved NumPy support:

      After the transition to the Iterable protocol has succeeded, the code base should
      have changed so much that we can focus on the real goal:

      • Supporting Iterables for multidimensional NumPy arrays or generators that produce them.

      This chapter will become more concrete at a later time.


      .
      .
      .
      .
      .


      This is the previous analysis

      PySide needs to be more user-friendly when interfacing to other packages.

      The most prominent example is NumPy, but it applies to other packages like SciPy, Pandas and MatPlotLib as well.

      After looking into this issue, it appears to be a two-fold problem:

      a) Many types support only List instead of allowing any sequence,

      b) The error messages are extremely misleading and wrong.

      Examples for a):

      There are many locations where PySide accepts a list only, although a sequence would be ok as well. That would allow for many new container types from NumPy, for instance.

      This example says it uses a set, but it does not work:

      >>> QtCore.QItemSelection.fromSet({2, 3, 5})
      Traceback (most recent call last):
        File "<stdin>", line 1, in <module>
      TypeError: 'PySide2.QtCore.QItemSelection.fromSet' called with wrong argument types:
        PySide2.QtCore.QItemSelection.fromSet(set)
      Supported signatures:
        PySide2.QtCore.QItemSelection.fromSet(QSet)
      >>> 
      

      The same with the function fromVector does of course not allow an arbitrary sequence.

      >>> QtCore.QItemSelection.fromVector([1, 2, 3])
      Traceback (most recent call last):
        File "<stdin>", line 1, in <module>
      TypeError: 'PySide2.QtCore.QItemSelection.fromVector' called with wrong argument types:
        PySide2.QtCore.QItemSelection.fromVector(list)
      Supported signatures:
        PySide2.QtCore.QItemSelection.fromVector(list)
      >>> 
      

      but gives a very unintuitive error message.

      I propose to either

      • allow arbitrary sequences here, or
      • add a new method fromSequence.

      That would then work with any extension that uses the sequence protocol.

      Examples for b):

      When trying to find negative examples for a), I stumbled surprisingly into examples for b). PySide already supports interfacing to other packages by using abstract protocols.
      See the following example:

      >>> from PySide2 import *
      >>> import numpy as np
      >>> a = np.array((1,2,3,4))
      >>> QtGui.QMatrix2x2(a)
      PySide2.QtGui.QMatrix2x2((1, 2, 3, 4))
      >>> 
      

      Here is the example that gives the impression that NumPy is not supported:

      >>> a3 = np.array((1,2,3))
      >>> QtGui.QMatrix2x2(a3)
      Traceback (most recent call last):
        File "<stdin>", line 1, in <module>
      TypeError: 'PySide2.QtGui.QMatrix2x2' called with wrong argument types:
        PySide2.QtGui.QMatrix2x2(numpy.ndarray)
      Supported signatures:
        PySide2.QtGui.QMatrix2x2(list)
        PySide2.QtGui.QMatrix2x2(PySide2.QtGui.QMatrix2x2)
      >>> 
      

      This problem seems to apply to the matrices, only. The error messages are very wrong, because the general sequence protocol is supported, but it says list. When you look at the file

      exists_{platf}_{version}_ci.py
      

      instead, you see that it says sequence instead. But this is also still not completely correct, since the signature module needs more work on correct types, too.

      First Attempt

      My impression is that before adding a new sequence support that serves many extensions, we should try to

      • improve error messages (re-write them using the signature module)
      • write a tool that checks every function signature for functionality.

      When that is working well enough that we can trust error messages, then we should think of new functionality.

      Maybe the topic of this task needs to be changed?

        Attachments

          Issue Links

          For Gerrit Dashboard: PYSIDE-795
          # Subject Branch Project Status CR V

            Activity

              People

              • Assignee:
                ctismer Christian Tismer
                Reporter:
                ctismer Christian Tismer
                RnD Owner:
                Alex Blasche
              • Votes:
                1 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated: