Uploaded image for project: 'Qt for Python'
  1. Qt for Python
  2. PYSIDE-834

Move injected code from typesystems

    Details

    • Type: User Story
    • Status: Closed
    • Priority: P3: Somewhat important
    • Resolution: Done
    • Affects Version/s: 5.11.2
    • Fix Version/s: 5.12.0
    • Component/s: PySide
    • Labels:
      None
    • Platform/s:
      All

      Description

      I went through the typesystem XML files and extract
      the code inside "inject-code" tags which is not
      stored on templates, and put them on a main directory
      called glue on the top of the modules sources.

      Having all these pieces of code on cpp files allows us
      to not have to modifying C++ code inside XML files,
      which is quite tedious considering that one need to escape
      some symbols.

      The following typesystems were reviewed:

      • QtCore
      • QtGui
      • QtWidgets

      Besides looking into the typesystem of the other modules
      we can consider transforming some templates into a separate
      file.
      We need to take care that in some cases we use templates
      modifying their parameters, so I don't know if that is
      possible having the source of the template on a separate
      cpp file.

      Pending tasks:

      • Review missing modules
      • Analyze how convenient it's to extract some static templates too

        Attachments

        1. pyside834.xslt
          0.6 kB
          Friedemann Kleint
        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

            • Assignee:
              crmaurei Cristian Maureira-Fredes
              Reporter:
              crmaurei Cristian Maureira-Fredes
              RnD Owner:
              Alex Blasche
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: