Uploaded image for project: 'Qt for Python'
  1. Qt for Python
  2. PYSIDE-882

Install target adds many empty directories from the build system

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: P4: Low
    • Resolution: Done
    • Affects Version/s: 5.12.0
    • Fix Version/s: 5.12.1
    • Component/s: PySide
    • Labels:
      None
    • Platform/s:
      Linux/X11
    • Commits:
      77265fcedc3411fb70e149cf9d9cd4f549de80e6 (pyside/pyside-setup/5.12)

      Description

      The installation of the hinting files also copies many unrelated directories, e.g. */CMakefiles/ and all the other build directories below.

      This is due to https://github.com/qtproject/pyside-pyside-setup/commit/14af709e10fa8a2e3c84094c13ebdda9833be124#diff-e6a90961d3665c0d196e71fcb67c8a0e

      The install(DIRECTORY ... FILES_MATCHING *.pyi command does not exclude empty directories from the base directory:
      https://cmake.org/cmake/help/v3.13/command/install.html#installing-directories

      The FILES_MATCHING option may be given before the first match option to disable installation of files (but not directories) not matched by any expression.

        Attachments

        For Gerrit Dashboard: PYSIDE-882
        # Subject Branch Project Status CR V

          Activity

            People

            Assignee:
            crmaurei Cristian Maureira-Fredes
            Reporter:
            bruns Stefan Brüns
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Gerrit Reviews

                There are no open Gerrit changes