Uploaded image for project: 'Qbs ("Cubes")'
  1. Qbs ("Cubes")
  2. QBS-1601

Variable substitution in Info.plist files broken for '@VAR@' syntax

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • Not Evaluated
    • 1.18.0
    • 1.14.0, 1.15.0, 1.16.0, 1.17.0
    • Platforms: Darwin
    • None
    • macOS
    • 759ec8419abab4433bf0d85c2414708fd664db82 (qbs/qbs/master)

    Description

      I was using the @ICON@ style for variables in my Info.plist file and since Qbs 1.14, those replacements no longer work.

      This turned out to be due to change ad11bb7383bf730ca0241af24a8b4179af157c7f, since now it searches for the last occurrence of "@" and then tries to find the next, which never works.

      I realize this notation is not actually documented (at least not mentioned at https://doc.qt.io/qbs/qml-qbsmodules-bundle.html#processInfoPlist-prop) so it might be fine to remove it entirely rather than fixing it up. A potential fix would be to add a flag to set the search direction for each of the possible syntaxes, or to find the first index when "syntaxes[i].open == syntaxes[i].close".

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            kandeler Christian Kandeler
            bjorn Thorbjørn Lindeijer
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes