Uploaded image for project: 'Qbs ("Cubes")'
  1. Qbs ("Cubes")
  2. QBS-182

Qt library naming function may erroneously contain version number

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • P1: Critical
    • 0.3
    • 0.3
    • General
    • None
    • OS X 10.8.2, Qt 5

    Description

      Git version: 159e5e61dbea6283bfc64d6a28bce2f44a1c2b92

      In share/qbs/modules/qt/qtfunctions.js the getLibraryName() function adds the Qt major version number to the filename of the library if the major version is >= 5.

      However, the Qt 5 RC2 for Mac package includes no such version number in its framework names, resulting in a failing build. I've attached a patch that would fix this issue. I'd submit a patch through Gerrit but I'm unsure whether qbs or the Qt 5 RC2 package is at fault here.

      Interestingly, the Windows library name adds the major version number only for Qt versions < 5.

      EDIT: Commit d725239c3e09c2b740a093265f6a9675fd2f8524 in qtbase by Thiago Macieira on 10th November would suggest that the RC2 packages are broken and this is not a bug in qbs, as the commit message states: "Insert the Qt major version (5) in the library names

      As discussed on the mailing list, insert the Qt major library version in
      the library name, so even the development files can be co-installed with
      Qt 4.

      Discussed-on: http://lists.qt-project.org/pipermail/development/2012-September/006545.html
      Discussed-on: http://lists.qt-project.org/pipermail/development/2012-September/006551.html"

      EDIT again: Thiago said on IRC that in the case of OS X, framework builds of Qt do not have the major version in the filename (all other platforms, including library builds on OS X, do). qbs should be updated to reflect this.

      Attachments

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              jbornema Joerg Bornemann
              jakepetroules Jake Petroules (DO NOT ASSIGN ISSUES)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes