Uploaded image for project: 'Qbs ("Cubes")'
  1. Qbs ("Cubes")
  2. QBS-244

Appending 'minimumWindowsVersion' to 'subsystemSwitch' should be reconsidered

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • P2: Important
    • 0.3
    • 0.3
    • Platforms: Windows
    • None
    • Windows 7 (64-bit), MinGW-w64 (64-bit)
    • 88fdf28c0d499f6dea6193072e796c313e61c2b3

    Description

      In share/qbs/modules/cpp/GenericGCC.qbs:

      var minimumWindowsVersion = ModUtils.moduleProperty(product, "minimumWindowsVersion");
      if (minimumWindowsVersion) {
          var subsystemVersion = Windows.getWindowsVersionInFormat(minimumWindowsVersion, 'subsystem');
          if (subsystemVersion) {
              args.push(subsystemSwitch + ',' + subsystemVersion);
              args.push("-Wl,-osversion," + subsystemVersion);
          } else {
              print('WARNING: Unknown Windows version "' + minimumWindowsVersion + '"');
              args.push(subsystemSwitch);
          }
      }
      

      I'm very surprised to see this. Please, provide a link to official documentation where appending version number is clearly allowed.

      First of all, I could not find any documentation where this would be mentioned. Secondly, my bleeding-edge MinGW-w64 (64-bit) based on GCC 4.7.2 does not recognize it and starts barking. Thus, to be able to build with Qbs further, I had to remove the above snippet completely.

      I think you should reconsider it.

      Attachments

        For Gerrit Dashboard: QBS-244
        # Subject Branch Project Status CR V

        Activity

          People

            jakepetroules Jake Petroules (DO NOT ASSIGN ISSUES)
            haroogan hwgexohr
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes