Uploaded image for project: 'Qbs ("Cubes")'
  1. Qbs ("Cubes")
  2. QBS-396

Opening a WiX project crashes Qt Creator due to stack overflow

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: P1: Critical P1: Critical
    • 1.1.0
    • 1.0.1
    • General
    • None
    • c939d3bb79619229626ccd02ea7deabe5debf060

      In qbs::Internal::RuleGraph::topSort (src\lib\buildgraph\rulegraph.cpp:189) the stack overflows.

      This only occurs when I Depend on my new WiX module. Hmm... Fortunately it's reproducible with a very minimal example.

      Take this...

      import qbs
      
      Product {
      	Depends { name: "wix" }
      	type: "wixmsi"
      }
      

      Open in Qt Creator built from b034b0b with QBS 82cd73d + https://codereview.qt-project.org/#change,67733.

      I tracked this down to line 75 of WiXModule.qbs where the candleCompiler Rule lists "wixmsi" in its explicitlyDependsOn, which is the same as the type of the Product given in the example.

      Obviously, this should issue an error message instead of crashing.

      My desire was that the candleCompiler Rule would be dependent on all artifacts of all the Product's dependencies as noted by the comment. I'm not sure if that's currently possible so I listed those 3 items temporarily for development.

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            kandeler Christian Kandeler
            jakepetroules Jake Petroules (DO NOT ASSIGN ISSUES)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                There are no open Gerrit changes