Uploaded image for project: 'Qbs ("Cubes")'
  1. Qbs ("Cubes")
  2. QBS-400

Qt translations Rule writes to source directory

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • P2: Important
    • 1.1.0
    • 1.0.1
    • General
    • None
    • 072e8cf2e22aeb3c95ddcf525875df58cef93fd8

    Description

      I have the following product:

      import qbs 1.0
      
      Product {
          type: "qm"
          name: "translations"
          Depends { name: "Qt.core" }
          files: "*.ts"
      
          destinationDirectory: project.locale_install_dir // == "translations"
      
          Group {
              fileTagsFilter: product.type
              qbs.install: true
              qbs.installDir: product.destinationDirectory
          }
      }
      

      When building this, the resultant .qm file gets written to my source directory - {source}/translations/translations/blah.qm.

      Reason for this is... Qt.core.qmFilesDir, which is set to product.destinationDirectory, is a path. The location of my translations QBS file is {source}/translations, so qmFilesDir then becomes {source}/translations/translations, an absolute path, joined with the file name in the qm Rule. Solution: qmFilesDir should be a string.

      This regression was introduced in fdd6cb3 two weeks ago.

      Guess we have to be a little more careful about using the path type.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            jakepetroules Jake Petroules (DO NOT ASSIGN ISSUES)
            jakepetroules Jake Petroules (DO NOT ASSIGN ISSUES)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes