Uploaded image for project: 'Qbs ("Cubes")'
  1. Qbs ("Cubes")
  2. QBS-556

Typo in XcodeProbe::compareVersions()

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: P2: Important P2: Important
    • 1.2.1
    • 1.1.1, 1.2.0
    • General
    • None
    • 95ed35296e811d5ed2583e9ec84f1c26ce021a39

      src/app/qbs-setup-toolchains/xcodeprobe.cpp 86

      int XcodeProbe::compareVersions(const QString &v1, const QString &v2)
{
    QStringList v1L = v1.split(QLatin1Char('.'));
    QStringList v2L = v2.split(QLatin1Char('.'));
    int i = 0;
    while (v1.length() > i && v1.length() > i) { // <---
      ...
    }

}

      I think should be "while (v1.length() > i && v2.length() > i)"

        For Gerrit Dashboard: QBS-556
        # Subject Branch Project Status CR V
        83593,1 fix XcodeProbe::compareVersions 1.2 qbs/qbs Status: MERGED +2 0

            jbornema Joerg Bornemann
            maksqwe Maks Naumov
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                There are no open Gerrit changes