Uploaded image for project: 'Qt Design Studio'
  1. Qt Design Studio
  2. QDS-11892

Header files generated in the src folder do not contain include guards

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: P3: Somewhat important P3: Somewhat important
    • QDS 4.7.0
    • QDS 4.4
    • All Other Issues
    • None
    • Qt Design Studio 4.4.0 Based on Qt 6.5.4 (MSVC 2019, x86_64) Built on Jan 29 2024 01:28:58 From revision b3b6794dc8

      OS: Windows 11 Pro, Version 22H2, OS build 22621.2861.
      64-bit operating system, x64-based processor
    • Windows
    • 40a26adb8 (qds/dev)

      How to reproduce

      1. Create a New project in QDS

      Description

      All the header files in src folder do not contain include guards. E.g. app_environment.h

      /*
       * This file is automatically generated by Qt Design Studio.
       * Do not change.
      */
      
      #include <QGuiApplication>
      
      void set_qt_environment()
      {
          qputenv("QT_IM_MODULE", "qtvirtualkeyboard");
          qputenv("QT_VIRTUALKEYBOARD_DESKTOP_DISABLE", "1");
          qputenv("QT_AUTO_SCREEN_SCALE_FACTOR", "1");
          qputenv("QT_ENABLE_HIGHDPI_SCALING", "0");
          qputenv("QT_LOGGING_RULES", "qt.qml.connections=false");
          qputenv("QT_QUICK_CONTROLS_CONF", ":/qtquickcontrols2.conf");
          qputenv("QML_COMPAT_RESOLVE_URLS_ON_ASSIGNMENT", "1");
      } 

      These files are not included twice anyway, so it's a minor issue.

      This is however a violation of C++ best practices. Therefore copying a file to a real project might introduce problems.

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            knud Knud Dollereder
            piotrtanski Piotr Tański
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                There are no open Gerrit changes