Uploaded image for project: 'Qt Design Studio'
  1. Qt Design Studio
  2. QDS-8094

Creating a node and setting dynamic properties on it in same transaction doesn't work correctly

    XMLWordPrintable

Details

    Description

      Creating a node and setting dynamic properties on it in same transaction doesn't work correctly. The properties will appear in the duplicate but they will look like regular non-dynamic properties. This will cause rewriter to fail. If setting dynamic properties is done in a separate transaction, it'll work fine.

      Noticed when implementing support for duplicating material nodes with dynamic properties. See MaterialEditorView::duplicateMaterial() function. If the two transactions are combined, the duplication of material with dynamic properties won't work.

      See https://codereview.qt-project.org/c/qt-creator/qt-creator/+/440140

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            thohartm Thomas Hartmann
            e0348803 Miikka Heikkinen
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:

              Gerrit Reviews

                There are no open Gerrit changes