Details
-
Bug
-
Resolution: Fixed
-
P2: Important
-
None
-
QDS 4.1
-
None
-
4f11fae46 (qds/dev), e442eb9e4 (qds/4.1)
-
QDS Oulu - 2023 Week 17/18, QDS Oulu - 2023 Week 19/20
Description
qint64 currentSize = m_bytesBefore - QStorageInfo(m_targetPath.toFileInfo().dir()).bytesAvailable(); // We can not get the uncompressed size of the archive yet, that is why we use an // approximation. We assume a 50% compression rate. int progress = std::min(100ll, currentSize * 100 / m_compressedSize * 2); if (progress >= 0) { m_progress = progress; emit progressChanged(); } else { qWarning() << "FileExtractor has got negative progress. Likely due to QStorageInfo.";
the calculation of the progress line can crash
Attachments
For Gerrit Dashboard: QDS-9832 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
475999,2 | wip: qds: fix crash if for some reason compressedSize is 0 | qds/dev | qt-creator/qt-creator | Status: ABANDONED | -2 | 0 |
476225,4 | QmlDesigner: Fix crash in FileExtractor when compressed size is 0 | qds/dev | qt-creator/qt-creator | Status: MERGED | +2 | 0 |
476321,2 | QmlDesigner: Fix crash in FileExtractor when compressed size is 0 | qds/4.1 | qt-creator/qt-creator | Status: MERGED | +2 | 0 |