Uploaded image for project: 'Qt Safe Renderer'
  1. Qt Safe Renderer
  2. QSR-1007

Remove Redundant doDrawBitmap from qsaferenderer.cpp

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Won't Do
    • Icon: P3: Somewhat important P3: Somewhat important
    • QSR 2.1
    • QSR 1.2
    • Runtime, Testing
    • None
    • All

      While checking cachegrind output of the performance test, it turned out that the QSafeRenderer::doDrawBitmap() is not used by the SafeRenderer code anymore; all the bitmaps nowadays are in V3 format and implicitly marked internally as compressed. The performance tests used V3 format bitmap that didn't take advantage of RLE32 compression (and thus was in essense uncompressed) and so used only the doDrawCompressedBitmap() function.

      However, tst_qsaferenderer.cpp uses explicitly and implicitly doDrawBitmap() function in several places, so removing the doDrawBitmap() is non-trivial. It is safest to leave the function there for 1.2 even if it breaks the MISRA c++ rule to NOT have used code.

      Remember to remove the function and fix the test cases later on.

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            jani.launonen Jani Launonen (Inactive)
            jani.launonen Jani Launonen (Inactive)
            Veli-Pekka Heinonen Veli-Pekka Heinonen
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                There are no open Gerrit changes