Uploaded image for project: 'Qt Safe Renderer'
  1. Qt Safe Renderer
  2. QSR-1162

Fix Clan-tidy warning for the runtime

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Reported
    • Priority: P3: Somewhat important
    • Resolution: Unresolved
    • Affects Version/s: QSR 1.2
    • Fix Version/s: QSR 2.1
    • Component/s: Runtime
    • Labels:
      None

      Description

      There is a warning about the QSafelayoutReader::readData function which should be considered to fix.

      The following warning is from the QSafeLayoutReader::readData. This function works as expected the function is a pure virtual function.

      E:/teholapp/work/qtsaferenderer/src/saferenderer/qsafelayoutfilereader.cpp:88:5: Calling 'QSafeLayoutFileReader::readData'
      E:/teholapp/work/qtsaferenderer/src/saferenderer/qsafelayoutfilereader.cpp:94:35: Call to virtual method 'QSafeLayoutFileReader::readDataFromFile' during construction bypasses virtual dispatch
      E:/teholapp/work/qtsaferenderer/src/saferenderer/qsafelayoutfilereader.cpp:94:35: warning: Call to virtual method 'QSafeLayoutFileReader::readDataFromFile' during construction bypasses virtual dispatch [clang-analyzer-optin.cplusplus.VirtualCall]
      1: Calling 'QSafeLayoutFileReader::readData' in E:/teholapp/work/qtsaferenderer/src/saferenderer/qsafelayoutfilereader.cpp:88
      2: Call to virtual method 'QSafeLayoutFileReader::readDataFromFile' during construction bypasses virtual dispatch in E:/teholapp/work/qtsaferenderer/src/saferenderer/qsafelayoutfilereader.cpp:94
      E:/teholapp/work/qtsaferenderer/src/saferenderer/qsafelayoutresourcereader.cpp:81:5: Calling 'QSafeLayoutResourceReader::readData'
      E:/teholapp/work/qtsaferenderer/src/saferenderer/qsafelayoutresourcereader.cpp:88:35: Call to virtual method 'QSafeLayoutResourceReader::readDataFromFile' during construction bypasses virtual dispatch
      E:/teholapp/work/qtsaferenderer/src/saferenderer/qsafelayoutresourcereader.cpp:88:35: warning: Call to virtual method 'QSafeLayoutResourceReader::readDataFromFile' during construction bypasses virtual dispatch [clang-analyzer-optin.cplusplus.VirtualCall]
      1: Calling 'QSafeLayoutResourceReader::readData' in E:/teholapp/work/qtsaferenderer/src/saferenderer/qsafelayoutresourcereader.cpp:81
      2: Call to virtual method 'QSafeLayoutResourceReader::readDataFromFile' during construction bypasses virtual dispatch in E:/teholapp/work/qtsaferenderer/src/saferenderer/qsafelayoutresourcereader.cpp:88

       

        TestRail: Results

          Attachments

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            Activity

              People

              Assignee:
              teemu.holappa Teemu Holappa
              Reporter:
              teemu.holappa Teemu Holappa
              PM Owner:
              Veli-Pekka Heinonen Veli-Pekka Heinonen
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:

                  Gerrit Reviews

                  There are no open Gerrit changes

                    TestRail: Runs

                      TestRail: Cases