Uploaded image for project: 'Qt Safe Renderer'
  1. Qt Safe Renderer
  2. QSR-2361

Fix UnitTests "testTransitionFileReadingException4" and "testTransitionFileReadingException5"

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • P2: Important
    • Future QSR version
    • QSR 2.1
    • Testing
    • None

    Description

      These two unit tests are obscure, they are testing old and new way at once which makes the user wonder what is it actually testing.

      Unit testing should not branch in this way, old way and new way should have their own proper tests and not leave it up to random occurrence which way is being tested. The code comment in the first test mentions:

              // QSafeFileReader will not use QSafeByteArray, so the exception is different
              // than when using QSafeReasourceReader (and old way).
      

      so this branching should be removed and new unit tests added for both branches of code if needed.

      Also TestRail documentation needs to be fixed as a part of this bug fix.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            qtsaferendererteam Qt Safe Renderer Team
            jussi_witick Jussi Witick
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:

              Gerrit Reviews

                There are no open Gerrit changes