Uploaded image for project: 'Qt Safe Renderer'
  1. Qt Safe Renderer
  2. QSR-2386

Fix Clang-tidy unit tests warning

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • P3: Somewhat important
    • Future QSR version
    • QSR 2.1
    • Runtime, Testing
    • None

    Description

      When running Clang-tidy for runtime with unit tests also built, the following warnings are found:

      C:\Users\aarotone\Workspace\qtsaferenderer-runtime\tests\auto\saferenderer\saferenderer\tst_qsaferenderer.cpp:896:5: warning: Passed-by-value struct argument contains uninitialized data (e.g., field: 'A') [clang-analyzer-core.CallAndMessage]
      1: Assuming the condition is false in C:\Users\aarotone\Workspace\qtsaferenderer-runtime\tests\auto\saferenderer\saferenderer\tst_qsaferenderer.cpp:852
      2: expanded from macro 'QVERIFY' in C:\Qt2.1.0_RC1\6.5.4\mingw_64\include\QtTest\qtestcase.h:31
      3: Assuming the condition is false in C:\Users\aarotone\Workspace\qtsaferenderer-runtime\tests\auto\saferenderer\saferenderer\tst_qsaferenderer.cpp:852
      4: expanded from macro 'QVERIFY' in C:\Qt2.1.0_RC1\6.5.4\mingw_64\include\QtTest\qtestcase.h:31
      5: Taking false branch in C:\Users\aarotone\Workspace\qtsaferenderer-runtime\tests\auto\saferenderer\saferenderer\tst_qsaferenderer.cpp:852
      6: expanded from macro 'QVERIFY' in C:\Qt2.1.0_RC1\6.5.4\mingw_64\include\QtTest\qtestcase.h:31
      7: Loop condition is false. Exiting loop in C:\Users\aarotone\Workspace\qtsaferenderer-runtime\tests\auto\saferenderer\saferenderer\tst_qsaferenderer.cpp:852
      8: expanded from macro 'QVERIFY' in C:\Qt2.1.0_RC1\6.5.4\mingw_64\include\QtTest\qtestcase.h:29
      9: Assuming the condition is false in C:\Users\aarotone\Workspace\qtsaferenderer-runtime\tests\auto\saferenderer\saferenderer\tst_qsaferenderer.cpp:873
      10: expanded from macro 'QVERIFY' in C:\Qt2.1.0_RC1\6.5.4\mingw_64\include\QtTest\qtestcase.h:31
      11: Taking false branch in C:\Users\aarotone\Workspace\qtsaferenderer-runtime\tests\auto\saferenderer\saferenderer\tst_qsaferenderer.cpp:873
      12: expanded from macro 'QVERIFY' in C:\Qt2.1.0_RC1\6.5.4\mingw_64\include\QtTest\qtestcase.h:31
      13: Loop condition is false. Exiting loop in C:\Users\aarotone\Workspace\qtsaferenderer-runtime\tests\auto\saferenderer\saferenderer\tst_qsaferenderer.cpp:873
      14: expanded from macro 'QVERIFY' in C:\Qt2.1.0_RC1\6.5.4\mingw_64\include\QtTest\qtestcase.h:29
      15: Assuming the condition is false in C:\Users\aarotone\Workspace\qtsaferenderer-runtime\tests\auto\saferenderer\saferenderer\tst_qsaferenderer.cpp:884
      16: expanded from macro 'QVERIFY' in C:\Qt2.1.0_RC1\6.5.4\mingw_64\include\QtTest\qtestcase.h:31
      17: Taking false branch in C:\Users\aarotone\Workspace\qtsaferenderer-runtime\tests\auto\saferenderer\saferenderer\tst_qsaferenderer.cpp:884
      18: expanded from macro 'QVERIFY' in C:\Qt2.1.0_RC1\6.5.4\mingw_64\include\QtTest\qtestcase.h:31
      19: Loop condition is false. Exiting loop in C:\Users\aarotone\Workspace\qtsaferenderer-runtime\tests\auto\saferenderer\saferenderer\tst_qsaferenderer.cpp:884
      20: expanded from macro 'QVERIFY' in C:\Qt2.1.0_RC1\6.5.4\mingw_64\include\QtTest\qtestcase.h:29
      21: Passed-by-value struct argument contains uninitialized data (e.g., field: 'A') in C:\Users\aarotone\Workspace\qtsaferenderer-runtime\tests\auto\saferenderer\saferenderer\tst_qsaferenderer.cpp:896

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            qtsaferendererteam Qt Safe Renderer Team
            aarotone Aapo Rotonen
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:

              Gerrit Reviews

                There are no open Gerrit changes