Uploaded image for project: 'Qt Safe Renderer'
  1. Qt Safe Renderer
  2. QSR-959

Animation duration value validation

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • P2: Important
    • QSR 2.1
    • QSR 1.2
    • Tooling
    • None

    Description

      duration: 0xabc 

      The decimal value is 2748 and the following issue is detected as expected:

      D:\QtQSR1.2\X_RC3_tests\TC_R2.3.4_Host_Win_10\indicators_R2345\MainForm.ui.qml:-1: error: Animation steps is bigger than SafeRenderer::Constraints::MAX_ANIMATION_STEPS. Transition is ignored.

      But if the value is entered without 0x prefix 

      duration: abc or duration: äääääää

      then the issue is not popping up, and the animation is not rendered.

      So it seems that there is no full input data validation.

      Negative values are ignored but the warning message is not exactly correct:

      D:\QtQSR1.2\X_RC3_tests\TC_R2.3.4_Host_Win_10\indicators_R2345\MainForm.ui.qml:-1: error: Animation steps is bigger than SafeRenderer::Constraints::MAX_ANIMATION_STEPS. Transition is ignored.

      Besides the duration type is described as int, which can hold negative values.

      The int type refers to a whole number, e.g. 0, 10, or -20.
      The possible int values range from around -2000000000 to around 2000000000, although most types will only accept a reduced range (which they mention in their documentation).

      Do we have any limitations mentioned for the duration?

       

      Attachments

        For Gerrit Dashboard: QSR-959
        # Subject Branch Project Status CR V

        Activity

          People

            teemu.holappa Teemu Holappa
            assaarel Asmo Saarela (Inactive)
            Veli-Pekka Heinonen Veli-Pekka Heinonen
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes