Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-100137

qmlcompiler should construct QColors using QColorConstants, not by string

    XMLWordPrintable

Details

    Description

      The QML compiler translates colour properties to strings, it seems:

       

      qt5-build-2/qtdeclarative/tests/auto/qml/qmltc/.qmltc/tst_qmltc_nodiskcache/properties.cpp:86: this->m_colorP = QStringLiteral("blue");

      This is needlessly inefficient. For named values, it should use QColorConstants::blue, in this case, and for RGB triples or ARGB quads the corresponding QColor(int, ..., int) ctor.

      Attachments

        Issue Links

          relates to

          User Story - Created by Jira Software - do not edit or delete. Issue type for a user story. QTBUG-105538 qmltc evolution collection task

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Open

          Task - A task that needs to be done. QTBUG-118323 qmllint: produce warnings for string to valuetype conversions

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Open

          Task - A task that needs to be done. QTBUG-101389 Port QColor's from-string API to QAnyStringView

          • P3: Somewhat important - Should be fixed, but doesn't affect the release in any way.
          • Closed
          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              qtqmlteam Qt Qml Team User
              mmutz Marc Mutz
              Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:

                Gerrit Reviews

                  There are no open Gerrit changes