Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-100428

qOffsetStringArray(): store consecutive duplicate strings only once

XMLWordPrintable

      Acceptance criterion:

      1. all existing tests still pass
      2. the following new tests don't fail:
      {
    constexpr auto table = qOffsetStringArray("Foo", "Foo", "");
    QVERIFY(table.viewAt(0) == "Foo");
    QVERIFY(table.viewAt(1) == "Foo");
    QVERIFY(table.viewAt(2) == "");
    QCOMPARE(table.m_string.size(), 4);
}
{
    constexpr auto table = qOffsetStringArray("Foo", "", "Foo");
    QVERIFY(table.viewAt(0) == "Foo");
    QVERIFY(table.viewAt(1) == "");
    QVERIFY(table.viewAt(2) == "Foo");
    QCOMPARE(table.m_string.size(), 8); // not de-duplicated, because not adjacent
}

      This level would suffice to port qglobal.cpp's list of Android names (version_strings) to qOffsetStringArray.

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            cnn Qt Core & Network
            mmutz Marc Mutz
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:

                There are no open Gerrit changes