Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-100630

PdfLinkModel don't give the right rect everytime

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • P2: Important
    • 6.7.1
    • 5.15.8
    • PDF
    • None
    • All
    • b78c78349 (dev), 5642f33e1 (6.7), 61a65ca96 (6.6), ac447e8dc (dev), b0e44197d (6.5), ff44bee52 (6.7)

    Description

      The rect value of the links is not always correct when using PdfLinkModel .

      According to the google code found here:

      https://chromium.googlesource.com/chromium/src/+/2355c635ab7c530c0191c12d4e191861055d696b/pdf/pdfium/pdfium_page.cc

      in the function void PDFiumPage::PopulateAnnotationLinks(), you can see that the values are sometime swapped. The method is a little more complex than Qt is doing this in the function void QPdfLinkModelPrivate::update(), they use also FPDFLink_CountQuadPoints.

      I was able to a patch in qml to obtain the right value, but this one should be done correctly in  QPdfLinkModelPrivate::update().

      Attachments

        1. quadpoints.png
          quadpoints.png
          52 kB
        2. rects.png
          rects.png
          50 kB
        3. screenshot-1.png
          screenshot-1.png
          96 kB
        4. test.pdf
          14.73 MB
        5. without-swap.png
          without-swap.png
          49 kB

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-123725 PDFSearchModel is not considering page rotation

          • Not Evaluated - Not yet evaluated/prioritized
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-120764 PDF Viewer Widget example search error

          • P1: Critical - Urgent and Important, will STOP the release if matched with set FixVersion field. This includes regressions from the last version that are not edge cases; Data loss; Build issues; All but the most unlikely crashes/lockups/hanging; Serious usability issues and embarrassing bugs & Bugs critical to a deliverable. This is the highest possible priority for requirements.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-106565 The coordinate of QPdfSelection seems like to be wrong when pdf page contains non-displayable area

          • P3: Somewhat important - Should be fixed, but doesn't affect the release in any way.
          • Closed
          For Gerrit Dashboard: QTBUG-100630
          # Subject Branch Project Status CR V
          554939,1 Convert "page" <-> "view" coordinates for PdfSelection and LinkModel tqtc/lts-6.5 qt/tqtc-qtwebengine Status: NEW +2 0
          418152,12 PdfLinkModel: if quadpoints available, convert to rects dev qt/qtwebengine Status: MERGED +2 0
          418153,2 QPdfLinkModel: deal with flipped rectangle coordinates dev qt/qtwebengine Status: MERGED +2 0
          418482,4 WIP use rotation dev qt/qtwebengine Status: ABANDONED -2 0
          549945,2 WIP Convert link bounds properly in QPdfLinkModel dev qt/qtwebengine Status: ABANDONED -2 0
          549946,10 Convert "page" <-> "view" coordinates for PdfSelection and LinkModel dev qt/qtwebengine Status: MERGED +2 0
          550813,3 Convert "page" <-> "view" coordinates for PdfSelection and LinkModel 6.7 qt/qtwebengine Status: MERGED +2 0
          550870,2 Convert "page" <-> "view" coordinates for PdfSelection and LinkModel 6.6 qt/qtwebengine Status: MERGED +2 0
          551235,3 Convert "page" <-> "view" coordinates for PdfSelection and LinkModel 6.5 qt/qtwebengine Status: MERGED +2 0
          551584,2 PdfLinkModel: if quadpoints available, convert to rects 6.7 qt/qtwebengine Status: MERGED +2 0

          Activity

            People

              srutledg Shawn Rutledge
              majuca Jean-Luc Gyger
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: