Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-102465

Finish migration to qsizetype [QXmlStreamReader]

XMLWordPrintable

    • 5
    • b94ec982c1 (qt/qtbase/dev) b94ec982c1 (qt/tqtc-qtbase/dev) 2070be1491 (qt/qtbase/6.3)
    • Team B Foundation Sprint 55, Team B Foundation Sprint 56

      Let's be honest: the change from int to qsizetype sizes in Qt 6.0 was more than rushed. Half the API and a good chunk of implementation code is still using int when it should be using qsizetype, and we have been papering over this issue by making qMin() allow mixed-type arguments and, apparently, by removing the annoying MSVC warnings that, in Qt 5, so nicely pin-pointed all these implicit conversions as hard errors.

      There are several real bugs in the QXmlStream* code corresponding to int/qsizetype.

        1.
        		 Data truncation in XmlStringRef Technical task Closed Marc Mutz
        2.
        		 QString tagStackStringStorage can't actually contain more than 2Gi characters Technical task Closed Marc Mutz
        For Gerrit Dashboard: QTBUG-102465
        # Subject Branch Project Status CR V
        409899,2 QXmlStreamReader: port readBufferPos from int to qsizetype dev qt/qtbase Status: MERGED +2 0
        409900,2 QXmlStreamWriter: replace indexed with ranged for loops dev qt/qtbase Status: MERGED +2 0
        409902,2 QXmlStreamReader: port some int → qsizetype dev qt/qtbase Status: MERGED +2 0
        409903,2 QXmlStreamWriter: port Private::write(p, n) from int to qsizetype dev qt/qtbase Status: MERGED -1 0
        409985,2 QXmlStreamReader: port another indexed to ranged for loop dev qt/qtbase Status: MERGED +2 0
        409986,2 QXmlStreamReader: port Value::pos from int to qsizetype dev qt/qtbase Status: MERGED +2 0
        409987,3 QXmlStreamReader: port Value::prefix from int to qint16 dev qt/qtbase Status: MERGED +2 0
        409990,2 QXmlStreamReader: port the last two int/qsizetype mismatches dev qt/qtbase Status: MERGED +2 0
        409991,2 QXmlStreamReader: port Value::len from int to qsizetype dev qt/qtbase Status: MERGED +2 0
        410122,2 QXmlStreamReader: port readBufferPos from int to qsizetype 6.3 qt/qtbase Status: MERGED +2 0
        410125,6 QXmlStreamReader: port some int → qsizetype 6.3 qt/qtbase Status: MERGED +2 0
        410126,2 QXmlStreamWriter: port Private::write(p, n) from int to qsizetype 6.3 qt/qtbase Status: MERGED +2 0
        410127,2 QXmlStreamWriter: replace indexed with ranged for loops 6.3 qt/qtbase Status: MERGED +2 0
        410129,2 QXmlStreamReader: port Value::pos from int to qsizetype 6.3 qt/qtbase Status: MERGED +2 0
        410130,2 QXmlStreamReader: port Value::prefix from int to qint16 6.3 qt/qtbase Status: MERGED +2 0
        410131,2 QXmlStreamReader: port another indexed to ranged for loop 6.3 qt/qtbase Status: MERGED +2 0
        410132,2 QXmlStreamReader: port the last two int/qsizetype mismatches 6.3 qt/qtbase Status: MERGED +2 0
        410133,4 QXmlStreamReader: port Value::len from int to qsizetype 6.3 qt/qtbase Status: MERGED +2 0
        410134,2 QXmlStreamReader: port readBufferPos from int to qsizetype tqtc/lts-6.2 qt/tqtc-qtbase Status: MERGED +2 0
        410136,2 QXmlStreamWriter: replace indexed with ranged for loops tqtc/lts-6.2 qt/tqtc-qtbase Status: MERGED +2 0
        410141,4 QXmlStreamReader: port some int → qsizetype tqtc/lts-6.2 qt/tqtc-qtbase Status: MERGED +2 0
        410142,2 QXmlStreamWriter: port Private::write(p, n) from int to qsizetype tqtc/lts-6.2 qt/tqtc-qtbase Status: MERGED +2 0
        410143,2 QXmlStreamReader: port Value::pos from int to qsizetype tqtc/lts-6.2 qt/tqtc-qtbase Status: MERGED +2 0
        410144,2 QXmlStreamReader: port Value::prefix from int to qint16 tqtc/lts-6.2 qt/tqtc-qtbase Status: MERGED +2 0
        410145,2 QXmlStreamReader: port another indexed to ranged for loop tqtc/lts-6.2 qt/tqtc-qtbase Status: MERGED +2 0
        410146,2 QXmlStreamReader: port the last two int/qsizetype mismatches tqtc/lts-6.2 qt/tqtc-qtbase Status: MERGED +2 0
        410147,2 QXmlStreamReader: port Value::len from int to qsizetype tqtc/lts-6.2 qt/tqtc-qtbase Status: MERGED +2 0

            mmutz Marc Mutz
            mmutz Marc Mutz
            Vladimir Minenko Vladimir Minenko
            Alex Blasche Alex Blasche
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved:

                There are no open Gerrit changes