Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-102821

Global variable found in qeglfsx11integration.cpp

    XMLWordPrintable

Details

    • 9861fd09cb (qt/qtbase/dev) 9861fd09cb (qt/tqtc-qtbase/dev) 930d105dd7 (qt/qtbase/6.3) 930d105dd7 (qt/tqtc-qtbase/6.3) d8dfc44193 (qt/tqtc-qtbase/5.15) 8a758968eb (qt/tqtc-qtbase/6.2) d8dfc44193 (qt/tqtc-qtbase/tqtc/vxworks-5.15.10)

    Description

      The running variable has external linkage: https://code.woboq.org/qt5/qtbase/src/plugins/platforms/eglfs/deviceintegration/eglfs_x11/qeglfsx11integration.cpp.html#running

      This causes problems when a user's code also has a global variable called "running" and they statically link to Qt.

       

      Suggestion

      Turn it into a file-static variable: `static QAtomicInt running;`

      Attachments

        For Gerrit Dashboard: QTBUG-102821
        # Subject Branch Project Status CR V
        407282,3 eglfs_x11: Fix running flag linkage dev qt/qtbase Status: MERGED +2 0
        407756,2 eglfs_x11: Fix running flag linkage 6.3 qt/qtbase Status: MERGED +2 0
        407757,2 eglfs_x11: Fix running flag linkage tqtc/lts-6.2 qt/tqtc-qtbase Status: MERGED -1 0
        407758,2 eglfs_x11: Fix running flag linkage tqtc/lts-5.15 qt/tqtc-qtbase Status: MERGED +2 0

        Activity

          People

            lagocs Laszlo Agocs
            skoh-qt Sze Howe Koh
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes