Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-102838

[REG] QTBUG-629 fix have some unrelated change which caused degradation.

    XMLWordPrintable

Details

    • Bug
    • Resolution: Incomplete
    • P3: Somewhat important
    • None
    • 6.3.0, 5.15
    • Widgets: Itemviews
    • None
    • All

    Description

      https://bugreports.qt.io/browse/QTBUG-629 contains code review https://codereview.qt-project.org/c/qt/qtbase/+/99658 with comment  (https://codereview.qt-project.org/c/qt/qtbase/+/99658/comment/9aa7fdbe_84dbf84d)
      From which we see that this change was unrelated to the bug.

      "2 * " change caused regression in Tableau and we are reverting that part in each upgrade to keep views consistent. 

      Would it be possible revert this change by removing "2 * " from the function 
      int QHeaderView::minimumSectionSize() const
      {
      Q_D(const QHeaderView);
      if (d->minimumSectionSize == -1)

      { QSize strut = QApplication::globalStrut(); int margin = 2 * style()->pixelMetric(QStyle::PM_HeaderMargin, nullptr, this); if (d->orientation == Qt::Horizontal) return qMax(strut.width(), (fontMetrics().maxWidth() + margin)); return qMax(strut.height(), (fontMetrics().height() + margin)); }

      return d->minimumSectionSize;
      }
       

       

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            qt.team.quick.subscriptions Qt Quick and Widgets Team
            aapinyan Artak Apinyan
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes