Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-103313

Make qdbusxml2cpp include moc files for the header ("includemocs")

    XMLWordPrintable

Details

    • Task
    • Resolution: Done
    • P3: Somewhat important
    • 6.5.0 Beta1
    • 6.2.4, 6.3.0 RC
    • D-Bus
    • None
    • 5
    • aa99bf532d (qt/qtbase/dev) aa99bf532d (qt/tqtc-qtbase/dev)
    • Team B Foundation Sprint 60, Foundation Sprint 61, Foundation Sprint 62, Foundation Sprint 63, Foundation Sprint 64, Foundation Sprint 65

    Description

      qdbusxml2cpp has a --moc/-m option, but that only tells it to add an #include "filename.moc", ie. the moc file for the implementation file, to the generated file.

      What is missing is an option (--includemocs/-M) which includes the "moc_filename.cpp" file, ie. the moc file for the header file, too.

      This will become important once we teach cmake or automoc to reject adding includes to mocs_compilation.cpp, in order to enforce includemocs at built time.

      Acceptance criteria:

      1. qdbusxml2cpp has a new command line option (--includemocs/-M, naming subject to bikeshedding), which will include the moc file for the generated header into the generated cpp file.
      2. Use of the new switch is rolled out in at least qtconnectivity and qtbase

      Attachments

        Issue Links

          For Gerrit Dashboard: QTBUG-103313
          # Subject Branch Project Status CR V

          Activity

            People

              mate Máté Barany
              mmutz Marc Mutz
              Vladimir Minenko Vladimir Minenko
              Alex Blasche Alex Blasche
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes