Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-10335

QTextBrowser::openExternalLinks set to false might still call QDesktopServices::openUrl(url);

    XMLWordPrintable

Details

    Description

      In QTextBrowserPrivate::_q_activateAnchor() there is the code sequence 

      if ((openExternalLinks && url.scheme() != QLatin1String("file") && url.scheme() != QLatin1String("qrc") && !url.isRelative()) 
|| (url.isRelative() && !currentURL.isRelative() && currentURL.scheme() != QLatin1String("file") && currentURL.scheme() != QLatin1String("qrc"))) { 
QDesktopServices::openUrl(url); 
return;

      QDesktopServices::openUrl() should not be called anyway if openExternalLinks is false, so the second condition does not seem right.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            Unassigned Unassigned
            sanonymous Nokia Qt Support (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes